Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: rest gateway script #1856

Merged
merged 2 commits into from Feb 4, 2021
Merged

build: rest gateway script #1856

merged 2 commits into from Feb 4, 2021

Conversation

deepankarm
Copy link
Member

No description provided.

@deepankarm deepankarm requested a review from a team as a code owner February 4, 2021 10:18
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021 •
edited

Codecov Report

Merging #1856 (57d9154) into master (4dbf094) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1856   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files         146      146           
  Lines        6983     6983           
=======================================
  Hits         6000     6000           
  Misses        983      983
Impacted Files Coverage Δ
jina/peapods/runtimes/asyncio/rest/app.py 77.55% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dbf094...11920e2. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1001, delta to last 3 avg.: -17%
  • 🐎🐎🐎🐎 query QPS at 80, delta to last 3 avg.: +229%

Breakdown

Version Index QPS Query QPS
current 1001 80
0.9.28 1209 24
0.9.27 1229 24

Backed by latency-tracking. Further commits will update this comment.

rutujasurve94
rutujasurve94 approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@rutujasurve94 rutujasurve94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepankarm deepankarm merged commit 36292e3 into master Feb 4, 2021
@deepankarm deepankarm deleted the rest-gateway-script branch February 4, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rutujasurve94 rutujasurve94 rutujasurve94 approved these changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@BastinJafari BastinJafari Awaiting requested review from BastinJafari

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepankarm @rutujasurve94 @jina-bot