Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zmq): change identity from id to uuid #1857

Merged
merged 1 commit into from Feb 4, 2021
Merged

fix(zmq): change identity from id to uuid #1857

merged 1 commit into from Feb 4, 2021

Conversation

deepankarm
Copy link
Member

No description provided.

@deepankarm deepankarm requested a review from a team as a code owner February 4, 2021 10:21
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021 •
edited

Codecov Report

Merging #1857 (18d3ff3) into master (4dbf094) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1857   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files         146      146           
  Lines        6983     6983           
=======================================
  Hits         6000     6000           
  Misses        983      983

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dbf094...9119d9a. Read the comment docs.

@JoanFM JoanFM linked an issue Feb 4, 2021 that may be closed by this pull request
polling seems not to be working with jinad #1815
Closed
@github-actions
Copy link

github-actions bot commented Feb 4, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1157, delta to last 3 avg.: -1%
  • 🐢🐢 query QPS at 19, delta to last 3 avg.: -7%

Breakdown

Version Index QPS Query QPS
current 1157 19
0.9.28 1180 20
0.9.27 1157 20

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit a5bf1b6 into master Feb 4, 2021
@JoanFM JoanFM deleted the fix-zmq-identity branch February 4, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@CatStark CatStark Awaiting requested review from CatStark

@imsergiy imsergiy Awaiting requested review from imsergiy

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

polling seems not to be working with jinad
3 participants
@deepankarm @JoanFM @jina-bot