Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set proper default traversals #1859

Merged
merged 1 commit into from Feb 4, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 4, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner February 4, 2021 11:41
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/driver labels Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1859 (dc6e7e4) into master (11eb7c9) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
+ Coverage   85.95%   86.02%   +0.06%     
==========================================
  Files         145      146       +1     
  Lines        6943     6982      +39     
==========================================
+ Hits         5968     6006      +38     
- Misses        975      976       +1     
Impacted Files Coverage Δ
jina/drivers/querylang/reverse.py 100.00% <100.00%> (ø)
jina/drivers/querylang/select.py 89.65% <100.00%> (ø)
jina/drivers/querylang/sort.py 100.00% <100.00%> (ø)
jina/executors/indexers/cache.py 97.10% <0.00%> (-0.09%) ⬇️
jina/proto/jina_pb2.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/types/mixin.py 96.29% <0.00%> (ø)
jina/jaml/helper.py 93.89% <0.00%> (+0.04%) ⬆️
jina/types/sets/document.py 94.11% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11eb7c9...dc6e7e4. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1125, delta to last 3 avg.: +0%
  • 😶 query QPS at 19, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1125 19
0.9.28 1103 19
0.9.27 1132 19

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 5c07c3e into master Feb 4, 2021
@hanxiao hanxiao deleted the fix-traversal-querylang branch February 4, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/driver size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants