Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(segmenter): improve segmenter docstring #1866

Merged
merged 1 commit into from Feb 5, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 4, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner February 4, 2021 14:14
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/executor labels Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1866 (c7f7f2a) into master (c526d2a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1866   +/-   ##
=======================================
  Coverage   85.93%   85.93%           
=======================================
  Files         146      146           
  Lines        6980     6980           
=======================================
  Hits         5998     5998           
  Misses        982      982           
Impacted Files Coverage Δ
jina/executors/segmenters/__init__.py 91.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c526d2a...ce304d6. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1169, delta to last 3 avg.: -2%
  • 😶 query QPS at 23, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1169 23
0.9.28 1193 23
0.9.27 1212 23

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 8af7c41 into master Feb 5, 2021
@nan-wang nan-wang deleted the docstring-segmenter branch February 5, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/executor size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants