refactor: remove unique id #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jina-bot
added
size/M
area/core
JoanFM
reviewed
Feb 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #1872 +/- ##
==========================================
+ Coverage 86.17% 86.33% +0.16%
==========================================
Files 146 145 -1
Lines 6982 6925 -57
==========================================
- Hits 6017 5979 -38
+ Misses 965 946 -19
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
JoanFM
requested changes
Feb 4, 2021
cristianmtr
reviewed
Feb 5, 2021
| match_idx = [] # type: List[Tuple[UniqueId, UniqueId, UniqueId, float]] | ||
| query_meta = {} # type: Dict[UniqueId, Dict] | ||
| match_meta = {} # type: Dict[UniqueId, Dict] | ||
| match_idx = [] # type: List[Tuple[str, str, str, float]] |
There was a problem hiding this comment.
Why are these types assigned behind a comment?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, but why are they comments in this case? They only reason to do that is if we want to support Python 2. Anyway, not a big deal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes #1606