New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(types): allow doc building from arbitrary json/dict #1877
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
- Coverage 85.96% 84.17% -1.80%
==========================================
Files 146 146
Lines 6982 6982
==========================================
- Hits 6002 5877 -125
- Misses 980 1105 +125
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite some magic in the CamelCase -> underscore_lower_case. But great thing to get this json conversion nailed.
this is provided by protobuf library btw |
.. highlight:: python | ||
.. code-block:: python | ||
|
||
d = Document({'id': '123', 'hello': 'world', 'tags': {'good': 'bye'}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this one!
No description provided.