Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeout can be negative #1879

Merged
merged 1 commit into from Feb 5, 2021
Merged

fix: timeout can be negative #1879

merged 1 commit into from Feb 5, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 5, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner February 5, 2021 12:31
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1879 (f731f26) into master (5e2767a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1879   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files         146      146           
  Lines        6982     6982           
=======================================
  Hits         6017     6017           
  Misses        965      965           
Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/client.py 82.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2767a...25a9c76. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 5, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1399, delta to last 3 avg.: -2%
  • 😶 query QPS at 27, delta to last 3 avg.: +1%

Breakdown

Version Index QPS Query QPS
current 1399 27
0.9.28 1430 26
0.9.27 1436 26

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 97c6b59 into master Feb 5, 2021
@JoanFM JoanFM deleted the fix-timeout-jinad branch February 5, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants