fix(types): fix extend in docset #1883
Conversation
jina-bot
added
size/S
area/core
| raise BadDocType('Each chunk should have the same granularity.') | ||
| self.chunks.extend(chunks) | ||
|
|
||
| # in case chunks have granularity defined, override |
There was a problem hiding this comment.
a warning should be raised if something is overriden for the user?
There was a problem hiding this comment.
this is your original logic in the code, which I found hard to understand.
There was a problem hiding this comment.
i keep it as it is as your original does not raise warning
There was a problem hiding this comment.
this is your original logic in the code, which I found hard to understand.
to be clear, I'm against the logic that a child granularity can decide parent's granularity
Codecov Report
@@ Coverage Diff @@
## master #1883 +/- ##
==========================================
- Coverage 86.28% 86.15% -0.14%
==========================================
Files 147 147
Lines 7006 7011 +5
==========================================
- Hits 6045 6040 -5
- Misses 961 971 +10
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
No description provided.