Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add visualization to doc type #1884

Merged
merged 4 commits into from Feb 6, 2021
Merged

feat(types): add visualization to doc type #1884

merged 4 commits into from Feb 6, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Feb 5, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner February 5, 2021 23:32
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/flow component/type labels Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1884 (fc9ad49) into master (6f68b20) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
- Coverage   86.28%   86.16%   -0.13%     
==========================================
  Files         147      147              
  Lines        7006     7003       -3     
==========================================
- Hits         6045     6034      -11     
- Misses        961      969       +8     
Impacted Files Coverage Δ
jina/flow/base.py 87.50% <100.00%> (-2.09%) ⬇️
jina/types/document/multimodal.py 96.29% <100.00%> (-1.71%) ⬇️
jina/types/sets/document.py 95.61% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a4457...9ea5f48. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 5, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1191, delta to last 3 avg.: -5%
  • 😶 query QPS at 24, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1191 24
0.9.28 1259 24
0.9.27 1253 24

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added the area/housekeeping This issue/PR is housekeeping label Feb 5, 2021
@hanxiao hanxiao merged commit 3ae7639 into master Feb 6, 2021
@hanxiao hanxiao deleted the feat-docs-plot branch February 6, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/flow component/type size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants