Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver): compoundindexer should turn on is_merge #1888

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Feb 6, 2021

without is_merge=True, all scored info is lost due to copy override

@hanxiao hanxiao requested a review from a team as a code owner February 6, 2021 20:42
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/resource labels Feb 6, 2021
@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #1888 (687c43e) into master (6716be2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1888   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files         147      147           
  Lines        7015     7015           
=======================================
  Hits         6053     6053           
  Misses        962      962           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6716be2...687c43e. Read the comment docs.

@hanxiao hanxiao merged commit a31a475 into master Feb 6, 2021
@hanxiao hanxiao deleted the fix-default-is-merge branch February 6, 2021 20:56
@github-actions
Copy link

github-actions bot commented Feb 6, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1015, delta to last 3 avg.: -5%
  • 🐢🐢 query QPS at 16, delta to last 3 avg.: -13%

Breakdown

Version Index QPS Query QPS
current 1015 16
0.9.29 1018 16
0.9.28 1121 20

Backed by latency-tracking. Further commits will update this comment.

@JoanFM
Copy link
Member

JoanFM commented Feb 6, 2021

@hanxiao @cristianmtr now I see why it was True by default, I think then we should set it back to True by default and find a fix for the problem of duplicated shapes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/resource size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants