Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): increase the default timeout-ready #1893

Merged
merged 1 commit into from Feb 7, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Feb 7, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner February 7, 2021 15:34
@jina-bot jina-bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Feb 7, 2021
@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #1893 (a617737) into master (b967c00) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1893   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files         147      147           
  Lines        7016     7016           
=======================================
  Hits         5916     5916           
  Misses       1100     1100           
Impacted Files Coverage Δ
jina/parsers/hub/build.py 100.00% <100.00%> (ø)
jina/parsers/peapods/pea.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b967c00...80d34a3. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 7, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1094, delta to last 3 avg.: +0%
  • 😶 query QPS at 20, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1094 20
0.9.30 1107 20
0.9.29 1096 20

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 59b4725 into master Feb 7, 2021
@hanxiao hanxiao deleted the fix-increase-default-timeout branch February 7, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants