test: fix test in flow, add back hw result check #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1897 +/- ##
===========================================
- Coverage 83.52% 67.74% -15.78%
===========================================
Files 148 148
Lines 7064 7062 -2
===========================================
- Hits 5900 4784 -1116
- Misses 1164 2278 +1114
Continue to review full report at Codecov.
|
JoanFM
requested changes
Feb 8, 2021
| @@ -32,7 +32,7 @@ def check_hello_world_results(html_path: str): | |||
| evaluation = soup.find_all('h3')[0].text | |||
| assert 'Precision@50' in evaluation | |||
| assert 'Recall@50' in evaluation | |||
| evaluation_results = re.findall("\d+\.\d+", evaluation) | |||
| evaluation_results = re.findall(r'\d+\.\d+', evaluation) | |||
| assert len(evaluation_results) == 2 | |||
| # not exact to avoid instability, but enough accurate to current results to raise some alarms | |||
| assert float(evaluation_results[0]) > 65.0 | |||
There was a problem hiding this comment.
can u set the 65.0 to 50.0? it is quite random the set of documents taken for the test and we were seeing times with lower value
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.