Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: logging for hub build tests #1923

Merged
merged 3 commits into from Feb 15, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner February 10, 2021 10:05
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/docker labels Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #1923 (7eb8839) into master (fb3d1db) will decrease coverage by 6.93%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
- Coverage   86.50%   79.57%   -6.94%     
==========================================
  Files         148      148              
  Lines        7042     7055      +13     
==========================================
- Hits         6092     5614     -478     
- Misses        950     1441     +491     
Impacted Files Coverage Δ
jina/docker/hubio.py 54.02% <92.85%> (-16.64%) ⬇️
jina/parsers/hub/new.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/list.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/pushpull.py 0.00% <0.00%> (-100.00%) ⬇️
jina/clients/request/asyncio.py 0.00% <0.00%> (-89.48%) ⬇️
jina/parsers/check.py 0.00% <0.00%> (-85.72%) ⬇️
jina/parsers/logger.py 0.00% <0.00%> (-85.72%) ⬇️
jina/parsers/export_api.py 0.00% <0.00%> (-85.72%) ⬇️
jina/docker/hubapi/local.py 18.39% <0.00%> (-70.12%) ⬇️
jina/docker/hubapi/remote.py 19.73% <0.00%> (-60.53%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f5b252...7eb8839. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 10, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1069, delta to last 3 avg.: +0%
  • 😶 query QPS at 20, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1069 20
1.0.0 1065 20
0.9.33 1074 20

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Feb 10, 2021
# test uses at executor level
if test_level >= BuildTestLevel.EXECUTOR:
logger.info(f'test executor')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some better messages can be recorded. Testing with test-level blah blah ..

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 47ae81f into master Feb 15, 2021
@nan-wang nan-wang deleted the refactor-logging-for-hub-build-tests branch February 15, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/docker size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants