New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: logging for hub build tests #1923
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
==========================================
- Coverage 86.50% 79.57% -6.94%
==========================================
Files 148 148
Lines 7042 7055 +13
==========================================
- Hits 6092 5614 -478
- Misses 950 1441 +491
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
jina/docker/hubio.py
Outdated
# test uses at executor level | ||
if test_level >= BuildTestLevel.EXECUTOR: | ||
logger.info(f'test executor') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some better messages can be recorded. Testing with test-level blah blah ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
No description provided.