New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: docstrings for parsers #1924
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
+ Coverage 82.00% 86.58% +4.57%
==========================================
Files 148 148
Lines 7092 7094 +2
==========================================
+ Hits 5816 6142 +326
+ Misses 1276 952 -324
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Co-authored-by: Yongxuanzhang <44033547+Yongxuanzhang@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…o docs-parsers-docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss lots of docstrings for public methods. Not sure if we need to add? If so I can help to add in this PR or in another new PR.
Sorry I didn't find out these in the first review. Just use 'interrogate' to double-check the coverage
@cristianmtr
Adding them now. I think I was running the wrong config of the linter here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
No description provided.