Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add to_blob converter to document #1929

Merged
merged 2 commits into from Feb 11, 2021
Merged

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Feb 11, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner February 11, 2021 11:01
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/type labels Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1929 (1a57ff6) into master (deff987) will decrease coverage by 1.95%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1929      +/-   ##
==========================================
- Coverage   86.50%   84.54%   -1.96%     
==========================================
  Files         148      148              
  Lines        7042     7055      +13     
==========================================
- Hits         6092     5965     -127     
- Misses        950     1090     +140     
Impacted Files Coverage Δ
jina/drivers/convert.py 90.90% <66.66%> (-9.10%) ⬇️
jina/types/document/converters.py 95.77% <85.71%> (-1.11%) ⬇️
jina/drivers/segment.py 100.00% <100.00%> (ø)
jina/clients/request/asyncio.py 0.00% <0.00%> (-89.48%) ⬇️
jina/jaml/parsers/flow/v1.py 48.14% <0.00%> (-46.30%) ⬇️
jina/clients/asyncio.py 51.51% <0.00%> (-39.40%) ⬇️
jina/jaml/parsers/flow/legacy.py 22.72% <0.00%> (-20.46%) ⬇️
jina/flow/mixin/async_crud.py 44.59% <0.00%> (-14.87%) ⬇️
jina/flow/asyncio.py 75.00% <0.00%> (-12.50%) ⬇️
jina/flow/base.py 81.25% <0.00%> (-8.60%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482903d...98a1e11. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 11, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1105, delta to last 3 avg.: -1%
  • 🐢🐢 query QPS at 16, delta to last 3 avg.: -14%

Breakdown

Version Index QPS Query QPS
current 1105 16
1.0.0 1128 18
0.9.33 1124 18

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 1ce5aa1 into master Feb 11, 2021
@hanxiao hanxiao deleted the feat-convert-to-blob branch February 11, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants