-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: detach BaseExecutable from Recursivity #1939
Conversation
373f1fd
to
5a11c83
Compare
eade6a3
to
e2159e3
Compare
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
e2159e3
to
f679a95
Compare
Codecov Report
@@ Coverage Diff @@
## master #1939 +/- ##
==========================================
+ Coverage 83.95% 86.67% +2.72%
==========================================
Files 148 148
Lines 7092 7093 +1
==========================================
+ Hits 5954 6148 +194
+ Misses 1138 945 -193
Continue to review full report at Codecov.
|
f679a95
to
c379e35
Compare
c379e35
to
d6139ca
Compare
d6139ca
to
5534c39
Compare
5534c39
to
29d2d5f
Compare
29d2d5f
to
329212d
Compare
3d6371e
to
3fde444
Compare
3fde444
to
c951af1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
518a82e
to
ae98a03
Compare
ae98a03
to
981fc56
Compare
981fc56
to
150bc50
Compare
150bc50
to
dd430ad
Compare
I would not add the |
Let's keep it as it is now, there are 2 or 3 now, and the change should be inmediate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Changes introduced
Try to clarify the inheritance structure of
FastRecursiveMixin
andBaseRecursiveDriver
by turniong the latter in anothermixin
.Also try to change some Drivers into the new
FastRecursiveMixin
since seems to be an easy way to go.Benefits
FastRecursiveMixin
also inherit fromBaseRecursiveDriver
, which makes their inheritance structure very ambiguousBaseRecursiveDriver
toFastRecursiveMixin
by putting recursivity traversal of the documents as a mixin deattaching from the core of anExecutableDriver