Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(drivers): remove the legacy docstring #1941

Merged
merged 1 commit into from Feb 15, 2021

Conversation

nan-wang
Copy link
Member

docs(drivers): remove the legacy docstring

@nan-wang nan-wang requested a review from a team as a code owner February 14, 2021 14:56
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/driver labels Feb 14, 2021
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #1941 (88e2dd2) into master (1898092) will decrease coverage by 2.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
- Coverage   86.55%   84.07%   -2.48%     
==========================================
  Files         148      148              
  Lines        7079     7079              
==========================================
- Hits         6127     5952     -175     
- Misses        952     1127     +175     
Impacted Files Coverage Δ
jina/helloworld/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/components.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/helper.py 0.00% <0.00%> (-90.63%) ⬇️
jina/helloworld/chatbot/__init__.py 0.00% <0.00%> (-89.29%) ⬇️
jina/executors/devices.py 50.98% <0.00%> (-5.89%) ⬇️
jina/parsers/helloworld.py 95.00% <0.00%> (-5.00%) ⬇️
jina/logging/profile.py 67.71% <0.00%> (-3.15%) ⬇️
jina/flow/base.py 86.71% <0.00%> (-3.13%) ⬇️
jina/drivers/convert.py 90.90% <0.00%> (-3.04%) ⬇️
jina/drivers/evaluate.py 96.55% <0.00%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f9e97...88e2dd2. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 945, delta to last 3 avg.: +0%
  • 🐢🐢 query QPS at 13, delta to last 3 avg.: -15%

Breakdown

Version Index QPS Query QPS
current 945 13
1.0.0 942 15
0.9.33 946 15

Backed by latency-tracking. Further commits will update this comment.

@nan-wang nan-wang merged commit ce38429 into master Feb 15, 2021
@nan-wang nan-wang deleted the docs-fix-typo-baseaggregatematchesranker branch February 15, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/driver size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants