Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the typos and add links #1942

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Conversation

nan-wang
Copy link
Member

docs: fix the typos and add links

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #1942 (0695377) into master (1898092) will decrease coverage by 18.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1942       +/-   ##
===========================================
- Coverage   86.55%   67.77%   -18.78%     
===========================================
  Files         148      148               
  Lines        7079     7079               
===========================================
- Hits         6127     4798     -1329     
- Misses        952     2281     +1329     
Impacted Files Coverage Δ
jina/types/sets/document.py 61.53% <ø> (-35.39%) ⬇️
jina/docker/helper.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-97.50%) ⬇️
jina/optimizers/flow_runner.py 0.00% <0.00%> (-95.66%) ⬇️
jina/docker/hubapi/local.py 0.00% <0.00%> (-88.51%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f9e97...c3cce66. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1061, delta to last 3 avg.: +0%
  • 🐢🐢 query QPS at 17, delta to last 3 avg.: -8%

Breakdown

Version Index QPS Query QPS
current 1061 17
1.0.1 1069 17
1.0.0 1047 19

Backed by latency-tracking. Further commits will update this comment.

@@ -104,7 +104,7 @@ In Jina we use git's pre-commit hooks in order to make sure the code matches our
It's easy to configure it:

1. `pip install pre-commit`
1. `pre-commit install .`
1. `pre-commit install`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't notice this PR, and I made the same correction in an already merged PR :P

@nan-wang nan-wang merged commit 3b95d78 into master Feb 15, 2021
@nan-wang nan-wang deleted the docs-fix-precommit-readme branch February 15, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants