Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): rm duplicate wikipedia example #1946

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

alexcg1
Copy link
Member

@alexcg1 alexcg1 commented Feb 15, 2021

Max and I both added the wiki example so it got added twice! This PR:

  • removes Max's entry
  • expands title of my own to include "NLP" for better explanation

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #1946 (b241dab) into master (3b95d78) will increase coverage by 1.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1946      +/-   ##
==========================================
+ Coverage   82.00%   83.95%   +1.94%     
==========================================
  Files         148      148              
  Lines        7092     7092              
==========================================
+ Hits         5816     5954     +138     
+ Misses       1276     1138     -138     
Impacted Files Coverage Δ
jina/drivers/control.py 95.08% <0.00%> (+1.63%) ⬆️
jina/clients/base.py 80.83% <0.00%> (+1.66%) ⬆️
jina/drivers/search.py 98.14% <0.00%> (+1.85%) ⬆️
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (+2.18%) ⬆️
jina/drivers/convert.py 93.93% <0.00%> (+3.03%) ⬆️
jina/flow/mixin/crud.py 89.28% <0.00%> (+3.57%) ⬆️
jina/peapods/runtimes/zmq/zed.py 91.42% <0.00%> (+3.57%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 95.83% <0.00%> (+4.16%) ⬆️
jina/clients/helper.py 100.00% <0.00%> (+4.54%) ⬆️
jina/jaml/helper.py 93.89% <0.00%> (+6.87%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b95d78...620e942. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1115, delta to last 3 avg.: +0%
  • 🐢🐢 query QPS at 18, delta to last 3 avg.: -8%

Breakdown

Version Index QPS Query QPS
current 1115 18
1.0.1 1130 18
1.0.0 1113 20

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit d33552a into master Feb 15, 2021
@nan-wang nan-wang deleted the docs-readme-rm-dup-example branch February 15, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants