Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(types): add queryset docstrings #1948

Merged
merged 1 commit into from
Feb 16, 2021
Merged

docs(types): add queryset docstrings #1948

merged 1 commit into from
Feb 16, 2021

Conversation

Yongxuanzhang
Copy link
Contributor

No description provided.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/type labels Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #1948 (cdbe30d) into master (d33552a) will increase coverage by 1.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
+ Coverage   82.02%   83.95%   +1.93%     
==========================================
  Files         148      148              
  Lines        7092     7092              
==========================================
+ Hits         5817     5954     +137     
+ Misses       1275     1138     -137     
Impacted Files Coverage Δ
jina/types/querylang/queryset/dunderkey.py 100.00% <ø> (ø)
jina/types/querylang/queryset/helper.py 92.30% <ø> (ø)
jina/types/querylang/queryset/lookup.py 84.21% <ø> (ø)
jina/drivers/control.py 95.08% <0.00%> (+1.63%) ⬆️
jina/clients/base.py 80.83% <0.00%> (+1.66%) ⬆️
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (+2.18%) ⬆️
jina/drivers/convert.py 93.93% <0.00%> (+3.03%) ⬆️
jina/flow/mixin/crud.py 89.28% <0.00%> (+3.57%) ⬆️
jina/peapods/runtimes/zmq/zed.py 91.42% <0.00%> (+3.57%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 95.83% <0.00%> (+4.16%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33552a...cdbe30d. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1083, delta to last 3 avg.: +0%
  • 🐢🐢 query QPS at 18, delta to last 3 avg.: -6%

Breakdown

Version Index QPS Query QPS
current 1083 18
1.0.1 1083 18
1.0.0 1063 20

Backed by latency-tracking. Further commits will update this comment.

@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review February 16, 2021 02:12
@Yongxuanzhang Yongxuanzhang requested a review from a team as a code owner February 16, 2021 02:12
@nan-wang nan-wang merged commit 92960e7 into master Feb 16, 2021
@nan-wang nan-wang deleted the docs-update-queryset branch February 16, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants