Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: docstrings for drivers #1951

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

cristianmtr
Copy link
Contributor

No description provided.

@cristianmtr cristianmtr requested a review from a team as a code owner February 16, 2021 11:36
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase component/driver labels Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #1951 (466bfeb) into master (d153381) will decrease coverage by 0.88%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
- Coverage   86.52%   85.63%   -0.89%     
==========================================
  Files         148      148              
  Lines        7093     7093              
==========================================
- Hits         6137     6074      -63     
- Misses        956     1019      +63     
Impacted Files Coverage Δ
jina/drivers/convertdriver.py 93.93% <ø> (ø)
jina/drivers/encode.py 91.30% <ø> (-2.90%) ⬇️
jina/drivers/evaluate.py 98.27% <ø> (ø)
jina/drivers/querylang/select.py 72.41% <ø> (-17.25%) ⬇️
jina/drivers/predict.py 38.88% <50.00%> (-53.71%) ⬇️
jina/drivers/control.py 95.08% <100.00%> (ø)
jina/drivers/reduce.py 75.60% <0.00%> (-24.40%) ⬇️
jina/drivers/querylang/reverse.py 77.77% <0.00%> (-22.23%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d153381...086b881. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1056, delta to last 3 avg.: +0%
  • 🐢🐢 query QPS at 17, delta to last 3 avg.: -7%

Breakdown

Version Index QPS Query QPS
current 1056 17
1.0.1 1069 17
1.0.0 1046 19

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit adba5aa into master Feb 16, 2021
@nan-wang nan-wang deleted the docs-docstrings-drivers-contd branch February 16, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/driver size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants