Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor querylang test use types #1963

Merged
merged 1 commit into from Feb 18, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 17, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner February 17, 2021 13:03
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1963 (dd8fdd2) into master (f02f30c) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1963      +/-   ##
==========================================
- Coverage   86.58%   86.55%   -0.03%     
==========================================
  Files         148      148              
  Lines        7094     7094              
==========================================
- Hits         6142     6140       -2     
- Misses        952      954       +2     
Impacted Files Coverage Δ
jina/flow/base.py 87.50% <0.00%> (-2.35%) ⬇️
jina/peapods/runtimes/jinad/client.py 87.59% <0.00%> (+5.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02f30c...0df7226. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1073, delta to last 3 avg.: +1%
  • 🐢🐢 query QPS at 17, delta to last 3 avg.: -8%

Breakdown

Version Index QPS Query QPS
current 1073 17
1.0.1 1059 17
1.0.0 1057 19

Backed by latency-tracking. Further commits will update this comment.

Copy link
Contributor

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JoanFM JoanFM merged commit b1fab67 into master Feb 18, 2021
@JoanFM JoanFM deleted the test-refactor-querylang branch February 18, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants