Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test if ubuntu 18.04 has tests working #1981

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 19, 2021

No description provided.

@JoanFM JoanFM requested a review from hanxiao as a code owner February 19, 2021 08:22
@github-actions
Copy link

This PR closes: #18.04

@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1981 (d64aec2) into master (0f2dc89) will increase coverage by 1.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1981      +/-   ##
==========================================
+ Coverage   81.51%   82.81%   +1.30%     
==========================================
  Files         148      148              
  Lines        7107     7072      -35     
==========================================
+ Hits         5793     5857      +64     
+ Misses       1314     1215      -99     
Impacted Files Coverage Δ
jina/enums.py 95.83% <ø> (-0.12%) ⬇️
jina/flow/base.py 80.31% <100.00%> (-0.16%) ⬇️
jina/flow/builder.py 95.52% <100.00%> (+21.60%) ⬆️
jina/parsers/flow.py 100.00% <100.00%> (ø)
jina/drivers/evaluate.py 97.14% <0.00%> (+2.85%) ⬆️
jina/drivers/encode.py 94.20% <0.00%> (+2.89%) ⬆️
jina/drivers/segment.py 100.00% <0.00%> (+5.00%) ⬆️
jina/types/sets/document.py 96.92% <0.00%> (+7.69%) ⬆️
jina/executors/indexers/cache.py 96.92% <0.00%> (+7.69%) ⬆️
jina/drivers/querylang/sort.py 100.00% <0.00%> (+8.33%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f2dc89...251ba84. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1295, delta to last 3 avg.: +2%
  • 🐢🐢 query QPS at 20, delta to last 3 avg.: -8%

Breakdown

Version Index QPS Query QPS
current 1295 20
1.0.1 1275 20
1.0.0 1246 22

Backed by latency-tracking. Further commits will update this comment.

@nan-wang nan-wang merged commit cb32309 into master Feb 19, 2021
@nan-wang nan-wang deleted the test-ubuntu-18.04 branch February 19, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants