Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(document): add data_uri2blob converter #1982

Merged
merged 2 commits into from Feb 19, 2021
Merged

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Feb 19, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner February 19, 2021 09:20
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be tested

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/driver component/type labels Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1982 (5548b4e) into master (c379b09) will decrease coverage by 7.69%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1982      +/-   ##
==========================================
- Coverage   86.59%   78.89%   -7.70%     
==========================================
  Files         148      148              
  Lines        7107     7075      -32     
==========================================
- Hits         6154     5582     -572     
- Misses        953     1493     +540     
Impacted Files Coverage Δ
jina/enums.py 95.83% <ø> (-0.12%) ⬇️
jina/drivers/convertdriver.py 88.88% <66.66%> (-5.06%) ⬇️
jina/flow/base.py 80.57% <100.00%> (-9.27%) ⬇️
jina/flow/builder.py 95.52% <100.00%> (+21.60%) ⬆️
jina/parsers/flow.py 100.00% <100.00%> (ø)
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/clients/request/asyncio.py 0.00% <0.00%> (-89.48%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c379b09...58f31ec. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 19, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1092, delta to last 3 avg.: +0%
  • 🐢🐢 query QPS at 18, delta to last 3 avg.: -6%

Breakdown

Version Index QPS Query QPS
current 1092 18
1.0.1 1094 18
1.0.0 1091 20

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Feb 19, 2021
@hanxiao hanxiao merged commit b2c2a97 into master Feb 19, 2021
@hanxiao hanxiao deleted the feat-add-datauri2blob branch February 19, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants