Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CI should never skip last step #1990

Merged
merged 2 commits into from Feb 20, 2021
Merged

fix: CI should never skip last step #1990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00f4d8b
fix: ci should never skip last step
JoanFM Feb 19, 2021
062d290
ci: use new github action
JoanFM Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -149,6 +149,14 @@ jobs:
# just for blocking the merge until all parallel core-test are successful
success-all-test:
needs: [core-test, docker-image-test]
if: always()
runs-on: ubuntu-18.04
steps:
- run: echo "All Done"
- uses: technote-space/workflow-conclusion-action@v2
- name: Check Failure
if: env.WORKFLOW_CONCLUSION == 'failure'
run: exit 1
- name: Success
if: ${{ success() }}
run: echo "All Done"