Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI should never skip last step #1990

Merged
merged 2 commits into from Feb 20, 2021
Merged

fix: CI should never skip last step #1990

merged 2 commits into from Feb 20, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 19, 2021

The CI was successfull and I was allowed to merge even with failing tests.

According to this issue in github runner actions/runner#777 and documentation on github runners I believe this is the way to go

@JoanFM JoanFM requested a review from hanxiao as a code owner February 19, 2021 21:41
@jina-bot jina-bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Feb 19, 2021
@JoanFM
Copy link
Member Author

JoanFM commented Feb 19, 2021

image (15)

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1990 (7bc91e2) into master (6bf1d20) will decrease coverage by 4.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
- Coverage   86.73%   82.22%   -4.52%     
==========================================
  Files         148      148              
  Lines        7081     7084       +3     
==========================================
- Hits         6142     5825     -317     
- Misses        939     1259     +320     
Impacted Files Coverage Δ
jina/executors/rankers/__init__.py 93.02% <100.00%> (+0.52%) ⬆️
jina/clients/request/asyncio.py 0.00% <0.00%> (-89.48%) ⬇️
jina/docker/hubapi/local.py 18.39% <0.00%> (-70.12%) ⬇️
jina/docker/hubapi/remote.py 19.73% <0.00%> (-60.53%) ⬇️
jina/jaml/parsers/flow/v1.py 48.14% <0.00%> (-44.45%) ⬇️
jina/clients/asyncio.py 51.51% <0.00%> (-39.40%) ⬇️
jina/docker/helper.py 66.66% <0.00%> (-33.34%) ⬇️
jina/jaml/parsers/flow/legacy.py 22.72% <0.00%> (-20.46%) ⬇️
jina/docker/hubio.py 54.02% <0.00%> (-17.54%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 79.16% <0.00%> (-16.67%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704679e...062d290. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 19, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1128, delta to last 3 avg.: +0%
  • 😶 query QPS at 16, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1128 16
1.0.2 1125 16
1.0.1 1128 16

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM marked this pull request as draft February 19, 2021 22:21
@jina-bot jina-bot added size/S and removed size/XS labels Feb 19, 2021
@JoanFM
Copy link
Member Author

JoanFM commented Feb 19, 2021

@JoanFM JoanFM marked this pull request as ready for review February 19, 2021 23:35
@hanxiao hanxiao merged commit 81c4e80 into master Feb 20, 2021
@hanxiao hanxiao deleted the ci-no-skip-success branch February 20, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants