Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add darglint to ci #2007

Merged
merged 25 commits into from Feb 24, 2021
Merged

ci: add darglint to ci #2007

merged 25 commits into from Feb 24, 2021

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Feb 22, 2021

Add darglint to perform incremental docstring check.

@bwanglzu bwanglzu self-assigned this Feb 22, 2021
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #2007 (4a77e66) into master (99fbfe5) will decrease coverage by 2.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2007      +/-   ##
==========================================
- Coverage   88.03%   85.76%   -2.27%     
==========================================
  Files         183      202      +19     
  Lines       10460    11021     +561     
==========================================
+ Hits         9208     9452     +244     
- Misses       1252     1569     +317     
Flag Coverage Δ
daemon 50.38% <ø> (?)
jina 86.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/docker/hubapi/local.py 18.39% <0.00%> (-68.97%) ⬇️
jina/docker/hubapi/remote.py 19.73% <0.00%> (-60.53%) ⬇️
jina/docker/helper.py 66.66% <0.00%> (-33.34%) ⬇️
jina/docker/hubio.py 54.02% <0.00%> (-17.54%) ⬇️
jina/parsers/hub/__init__.py 90.00% <0.00%> (-5.00%) ⬇️
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (-3.65%) ⬇️
jina/peapods/peas/__init__.py 93.69% <0.00%> (-2.71%) ⬇️
jina/parsers/helper.py 48.66% <0.00%> (-2.00%) ⬇️
jina/docker/checker.py 83.33% <0.00%> (-1.86%) ⬇️
jina/peapods/runtimes/zmq/zed.py 91.48% <0.00%> (-1.42%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99fbfe5...4a77e66. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 22, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 966, delta to last 3 avg.: +0%
  • 🐢🐢 query QPS at 13, delta to last 3 avg.: -7%

Breakdown

Version Index QPS Query QPS
current 966 13
1.0.4 970 14
1.0.3 967 14

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM marked this pull request as ready for review February 22, 2021 11:43
@JoanFM JoanFM requested a review from hanxiao as a code owner February 22, 2021 11:43
Copy link
Contributor

@cristianmtr cristianmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test it in this PR with a dummy file that we can then remove?

@cristianmtr
Copy link
Contributor

To test

[] add malformed python file
[] add random text file to check that it ignores it

@cristianmtr cristianmtr self-assigned this Feb 22, 2021
@bwanglzu bwanglzu requested a review from a team as a code owner February 22, 2021 13:57
@jina-bot jina-bot added area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Feb 22, 2021
@bwanglzu
Copy link
Member Author

bwanglzu commented Feb 22, 2021

added a test.py, with a success case and a fail case, and a test.txt, this should be ignored.
image

@cristianmtr
Copy link
Contributor

Issue: it seems like it only checks changed files on the last sha, not on entire PR level.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Feb 22, 2021
@cristianmtr cristianmtr force-pushed the ci-lint-docstring branch 13 times, most recently from 2d8e6f1 to 54bc525 Compare February 23, 2021 13:04
@nan-wang nan-wang merged commit 0f6b961 into master Feb 24, 2021
@nan-wang nan-wang deleted the ci-lint-docstring branch February 24, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants