Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(logging): add profiling test #2016

Merged
merged 2 commits into from Feb 24, 2021
Merged

test(logging): add profiling test #2016

merged 2 commits into from Feb 24, 2021

Conversation

Yongxuanzhang
Copy link
Contributor

The previous test may fail, so change it to make sure it could pass and meanwhile illustrate the functionality.

@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #2016 (920b4a9) into master (99fbfe5) will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
- Coverage   88.03%   87.77%   -0.26%     
==========================================
  Files         183      202      +19     
  Lines       10460    11021     +561     
==========================================
+ Hits         9208     9674     +466     
- Misses       1252     1347      +95     
Flag Coverage Δ
daemon 50.48% <ø> (?)
jina 88.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/helper.py 48.66% <0.00%> (-2.00%) ⬇️
daemon/__init__.py 55.76% <0.00%> (ø)
daemon/models/status.py 100.00% <0.00%> (ø)
daemon/stores/__init__.py 100.00% <0.00%> (ø)
daemon/stores/helper.py 95.45% <0.00%> (ø)
daemon/stores/pea.py 95.45% <0.00%> (ø)
daemon/excepts.py 100.00% <0.00%> (ø)
daemon/api/endpoints/workspace.py 77.41% <0.00%> (ø)
daemon/api/endpoints/pea.py 86.11% <0.00%> (ø)
daemon/stores/flow.py 100.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99fbfe5...3f994f7. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 23, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 944, delta to last 3 avg.: -2%
  • 😶 query QPS at 13, delta to last 3 avg.: -5%

Breakdown

Version Index QPS Query QPS
current 944 13
1.0.4 969 13
1.0.3 960 13

Backed by latency-tracking. Further commits will update this comment.

@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review February 24, 2021 03:00
@Yongxuanzhang Yongxuanzhang requested a review from a team as a code owner February 24, 2021 03:00
Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 17a64e7 into master Feb 24, 2021
@nan-wang nan-wang deleted the test-logging-profiling branch February 24, 2021 03:05
@Yongxuanzhang Yongxuanzhang restored the test-logging-profiling branch February 24, 2021 03:24
@Yongxuanzhang Yongxuanzhang deleted the test-logging-profiling branch February 24, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants