Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme):update eah god #2030

Merged
merged 1 commit into from Feb 24, 2021
Merged

docs(readme):update eah god #2030

merged 1 commit into from Feb 24, 2021

Conversation

FionnD
Copy link
Contributor

@FionnD FionnD commented Feb 24, 2021

Added new image for EAH god

@FionnD FionnD requested a review from alexcg1 February 24, 2021 08:56
@FionnD FionnD requested a review from hanxiao as a code owner February 24, 2021 08:56
@jina-bot jina-bot added size/XS area/housekeeping This issue/PR is housekeeping labels Feb 24, 2021
@github-actions
Copy link

github-actions bot commented Feb 24, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1055, delta to last 3 avg.: -2%
  • 😶 query QPS at 17, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1055 17
1.0.4 1074 17
1.0.3 1081 17

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2030 (a57e566) into master (fb303b8) will decrease coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2030      +/-   ##
==========================================
- Coverage   87.33%   86.82%   -0.51%     
==========================================
  Files         202      202              
  Lines       11022    11022              
==========================================
- Hits         9626     9570      -56     
- Misses       1396     1452      +56     
Flag Coverage Δ
daemon 50.38% <ø> (+0.02%) ⬆️
jina 87.10% <ø> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/parsers/flow/v1.py 48.14% <0.00%> (-44.45%) ⬇️
jina/clients/asyncio.py 51.51% <0.00%> (-39.40%) ⬇️
jina/jaml/parsers/flow/legacy.py 22.72% <0.00%> (-20.46%) ⬇️
jina/flow/base.py 77.42% <0.00%> (-14.97%) ⬇️
jina/flow/mixin/async_crud.py 44.59% <0.00%> (-14.87%) ⬇️
jina/flow/asyncio.py 75.00% <0.00%> (-12.50%) ⬇️
jina/executors/crafters/__init__.py 92.85% <0.00%> (-7.15%) ⬇️
jina/jaml/helper.py 87.02% <0.00%> (-6.88%) ⬇️
jina/jaml/parsers/__init__.py 93.61% <0.00%> (-6.39%) ⬇️
jina/clients/__init__.py 90.00% <0.00%> (-5.00%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb303b8...6213a6b. Read the comment docs.

Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a deletion only

@FionnD
Copy link
Contributor Author

FionnD commented Feb 24, 2021

this looks like a deletion only

It looks like a replacement to me? @hanxiao https://imgur.com/a/TJiQGqc

@hanxiao hanxiao merged commit 10e85cc into master Feb 24, 2021
@hanxiao hanxiao deleted the docs-update-image branch February 24, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants