Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused pipeline encoder #2033

Merged
merged 2 commits into from Feb 24, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Feb 24, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner February 24, 2021 10:40
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/executor executor/encoder labels Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2033 (ec9746e) into master (10e85cc) will decrease coverage by 7.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
- Coverage   88.56%   81.10%   -7.47%     
==========================================
  Files         200      181      -19     
  Lines       10943    10367     -576     
==========================================
- Hits         9692     8408    -1284     
- Misses       1251     1959     +708     
Flag Coverage Δ
daemon 49.01% <ø> (-1.44%) ⬇️
jina 80.92% <ø> (-8.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/encoders/__init__.py 90.00% <ø> (+30.00%) ⬆️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-97.50%) ⬇️
jina/optimizers/flow_runner.py 0.00% <0.00%> (-95.66%) ⬇️
jina/optimizers/__init__.py 0.00% <0.00%> (-94.40%) ⬇️
jina/optimizers/discovery.py 0.00% <0.00%> (-80.27%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e85cc...ec9746e. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 24, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1083, delta to last 3 avg.: +0%
  • 😶 query QPS at 18, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1083 18
1.0.4 1069 17
1.0.3 1076 17

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit fbb8099 into master Feb 24, 2021
@JoanFM JoanFM deleted the refactor-remove-pipeline-encoder branch February 24, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants