Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: type annotation #2049

Merged
merged 12 commits into from Mar 9, 2021
Merged

docs: type annotation #2049

merged 12 commits into from Mar 9, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client labels Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #2049 (8fe4638) into master (c258e4a) will increase coverage by 1.47%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2049      +/-   ##
==========================================
+ Coverage   88.34%   89.82%   +1.47%     
==========================================
  Files         211      211              
  Lines       11104    11104              
==========================================
+ Hits         9810     9974     +164     
+ Misses       1294     1130     -164     
Flag Coverage Δ
daemon 50.85% <38.46%> (+0.01%) ⬆️
jina 90.29% <76.92%> (+1.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/sugary_io.py 92.10% <76.92%> (ø)
jina/helper.py 83.44% <0.00%> (+0.86%) ⬆️
jina/drivers/control.py 95.08% <0.00%> (+1.63%) ⬆️
jina/clients/base.py 83.19% <0.00%> (+1.68%) ⬆️
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (+2.18%) ⬆️
jina/types/message/__init__.py 88.20% <0.00%> (+2.56%) ⬆️
jina/drivers/convertdriver.py 97.22% <0.00%> (+2.77%) ⬆️
jina/flow/mixin/crud.py 89.65% <0.00%> (+3.44%) ⬆️
jina/peapods/runtimes/zmq/zed.py 91.48% <0.00%> (+3.54%) ⬆️
jina/peapods/pods/__init__.py 84.37% <0.00%> (+3.75%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd876d...90386e9. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 25, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1005, delta to last 3 avg.: +0%
  • 😶 query QPS at 14, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1005 14
1.0.7 1017 14
1.0.6 974 14

Backed by latency-tracking. Further commits will update this comment.

JoanFM
JoanFM previously requested changes Mar 7, 2021
jina/clients/sugary_io.py Outdated Show resolved Hide resolved
jina/clients/sugary_io.py Outdated Show resolved Hide resolved
@florian-hoenicke florian-hoenicke marked this pull request as ready for review March 8, 2021 22:56
@florian-hoenicke florian-hoenicke requested a review from a team as a code owner March 8, 2021 22:56
Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit ded7f75 into master Mar 9, 2021
@nan-wang nan-wang deleted the docs-type-annotations-io branch March 9, 2021 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants