Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hello): fix multimodal typo in yaml #2053

Merged
merged 1 commit into from Feb 26, 2021
Merged

fix(hello): fix multimodal typo in yaml #2053

merged 1 commit into from Feb 26, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Feb 26, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner February 26, 2021 10:58
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/resource labels Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #2053 (384b719) into master (c7d78c4) will decrease coverage by 20.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2053       +/-   ##
===========================================
- Coverage   88.83%   68.47%   -20.36%     
===========================================
  Files         200      181       -19     
  Lines       10925    10364      -561     
===========================================
- Hits         9705     7097     -2608     
- Misses       1220     3267     +2047     
Flag Coverage Δ
daemon ?
jina 68.47% <ø> (-20.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/ping.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/optimizer.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/checker.py 0.00% <0.00%> (-98.15%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-97.50%) ⬇️
jina/optimizers/flow_runner.py 0.00% <0.00%> (-95.66%) ⬇️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d78c4...b0c2e9e. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1242, delta to last 3 avg.: +0%
  • 😶 query QPS at 20, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1242 20
1.0.4 1210 20
1.0.3 1258 20

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hanxiao hanxiao merged commit fcbd7e4 into master Feb 26, 2021
@hanxiao hanxiao deleted the fix-typo-yaml branch February 26, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/resource size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants