Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: up timeout #2109

Merged
merged 1 commit into from Mar 4, 2021
Merged

ci: up timeout #2109

merged 1 commit into from Mar 4, 2021

Conversation

cristianmtr
Copy link
Contributor

No description provided.

@jina-bot jina-bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #2109 (3b8afd1) into master (b2b9b2e) will decrease coverage by 22.68%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2109       +/-   ##
===========================================
- Coverage   89.64%   66.95%   -22.69%     
===========================================
  Files         208      189       -19     
  Lines       11062    10502      -560     
===========================================
- Hits         9916     7032     -2884     
- Misses       1146     3470     +2324     
Flag Coverage Δ
daemon ?
jina 66.95% <ø> (-23.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/schemas/pod.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/ping.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/flow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/meta.py 0.00% <0.00%> (-100.00%) ⬇️
jina/docker/helper.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/driver.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/new.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/request.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/list.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/executor.py 0.00% <0.00%> (-100.00%) ⬇️
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e581f89...a7a4ebe. Read the comment docs.

JoanFM
JoanFM previously approved these changes Mar 3, 2021
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1183, delta to last 3 avg.: -1%
  • 😶 query QPS at 20, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1183 20
1.0.7 1199 20
1.0.6 1197 20

Backed by latency-tracking. Further commits will update this comment.

@maximilianwerk
Copy link
Member

Please also add for cd.yml.

Copy link
Member

@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristianmtr cristianmtr requested a review from JoanFM March 3, 2021 13:04
@hanxiao hanxiao merged commit 989d068 into master Mar 4, 2021
@hanxiao hanxiao deleted the ci-up-timeout branch March 4, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants