Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose env variable for workspace #2114

Merged
merged 1 commit into from Mar 5, 2021

Conversation

maximilianwerk
Copy link
Member

This is needed in order to use the dynamic workspace for the indexers.

@maximilianwerk maximilianwerk requested a review from a team as a code owner March 5, 2021 10:37
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase labels Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #2114 (1f163f2) into master (cb40b44) will decrease coverage by 10.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2114       +/-   ##
===========================================
- Coverage   89.74%   79.51%   -10.23%     
===========================================
  Files         211      192       -19     
  Lines       11054    10494      -560     
===========================================
- Hits         9920     8344     -1576     
- Misses       1134     2150     +1016     
Flag Coverage Δ
daemon 49.60% <0.00%> (-1.45%) ⬇️
jina 79.34% <0.00%> (-10.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/optimizers/__init__.py 0.00% <0.00%> (-97.12%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/flow_runner.py 0.00% <0.00%> (-97.78%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-97.50%) ⬇️
jina/optimizers/discovery.py 0.00% <0.00%> (-80.27%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb40b44...1f163f2. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 5, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1064, delta to last 3 avg.: +2%
  • 😶 query QPS at 15, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1064 15
1.0.7 1013 15
1.0.6 1060 15

Backed by latency-tracking. Further commits will update this comment.

@maximilianwerk maximilianwerk merged commit 9bbb076 into master Mar 5, 2021
@maximilianwerk maximilianwerk deleted the fix-optimizer-workspace branch March 5, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants