Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): rename silent to quiet #2122

Merged
merged 1 commit into from Mar 8, 2021
Merged

refactor(cli): rename silent to quiet #2122

merged 1 commit into from Mar 8, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Mar 8, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner March 8, 2021 01:16
@jina-bot jina-bot added size/L area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod labels Mar 8, 2021
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1101, delta to last 3 avg.: +0%
  • 😶 query QPS at 18, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1101 18
1.0.8 1113 18
1.0.7 1107 18

Backed by latency-tracking. Further commits will update this comment.

bwanglzu
bwanglzu approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is there a reason to remove apache badge?

btw, you rebase master will fix the ci error for docstring check.

@hanxiao hanxiao merged commit dd68773 into master Mar 8, 2021
@hanxiao hanxiao deleted the refactor-silent-to-quiet branch March 8, 2021 05:34
@hanxiao
Copy link
Member Author

hanxiao commented Mar 8, 2021

  1. keep badges in a single line
  2. APL 2.0 is already labeled on the github UI, redundant

@nan-wang nan-wang mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwanglzu bwanglzu bwanglzu approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanxiao @bwanglzu @jina-bot