Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: returns to return #2148

Merged
merged 1 commit into from Mar 11, 2021
Merged

Conversation

florian-hoenicke
Copy link
Member

@florian-hoenicke florian-hoenicke commented Mar 10, 2021

A small correction for the docstrings.
We had cases where we were using :returns: in the docstring, but it has to be :return:

Resolves #2149

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/logging component/type labels Mar 10, 2021
@florian-hoenicke florian-hoenicke linked an issue Mar 10, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2148 (071793e) into master (1fd79ae) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2148      +/-   ##
==========================================
+ Coverage   90.36%   90.43%   +0.07%     
==========================================
  Files         211      211              
  Lines       11201    11201              
==========================================
+ Hits        10122    10130       +8     
+ Misses       1079     1071       -8     
Flag Coverage Δ
daemon 50.43% <ø> (ø)
jina 90.89% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/logging/formatter.py 100.00% <ø> (ø)
jina/logging/logger.py 93.93% <ø> (ø)
jina/optimizers/__init__.py 97.14% <ø> (ø)
jina/optimizers/parameters.py 97.50% <ø> (ø)
jina/types/querylang/queryset/dunderkey.py 100.00% <ø> (ø)
jina/types/score/__init__.py 100.00% <ø> (ø)
jina/peapods/peas/__init__.py 91.89% <0.00%> (-1.81%) ⬇️
jina/peapods/zmq/__init__.py 82.01% <0.00%> (+2.13%) ⬆️
jina/clients/base.py 83.33% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd79ae...071793e. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 903, delta to last 3 avg.: -5%
  • 🐢🐢 query QPS at 13, delta to last 3 avg.: -7%

Breakdown

Version Index QPS Query QPS
current 903 13
1.0.8 952 14
1.0.7 966 13

Backed by latency-tracking. Further commits will update this comment.

@florian-hoenicke florian-hoenicke marked this pull request as ready for review March 11, 2021 08:11
@florian-hoenicke florian-hoenicke requested a review from a team as a code owner March 11, 2021 08:11
Copy link
Contributor

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Yongxuanzhang Yongxuanzhang merged commit f12a480 into master Mar 11, 2021
@Yongxuanzhang Yongxuanzhang deleted the refactor-returns-to-return branch March 11, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/logging component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor returns to return
3 participants