Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: kwargs without unpacking #2158

Merged
merged 8 commits into from Mar 15, 2021
Merged

docs: kwargs without unpacking #2158

merged 8 commits into from Mar 15, 2021

Conversation

florian-hoenicke
Copy link
Member

@florian-hoenicke florian-hoenicke commented Mar 11, 2021 •
edited

Pycharm raised a warning for this. Before, we had it mixed and now it is unified.
resolves #2160

@codecov
Copy link

codecov bot commented Mar 11, 2021 •
edited

Codecov Report

Merging #2158 (4de1b2f) into master (2940582) will increase coverage by 1.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
+ Coverage   88.86%   90.38%   +1.51%     
==========================================
  Files         211      211              
  Lines       11263    11263              
==========================================
+ Hits        10009    10180     +171     
+ Misses       1254     1083     -171
Flag Coverage Δ
daemon 50.22% <100.00%> (ø)
jina 90.83% <100.00%> (+1.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/websocket.py 90.47% <ø> (ø)
jina/drivers/__init__.py 93.90% <ø> (ø)
jina/drivers/cache.py 94.59% <ø> (ø)
jina/drivers/control.py 95.08% <ø> (+1.63%) ⬆️
jina/drivers/convertdriver.py 97.22% <ø> (+2.77%) ⬆️
jina/drivers/delete.py 100.00% <ø> (ø)
jina/drivers/evaluate.py 100.00% <ø> (ø)
jina/drivers/multimodal.py 91.89% <ø> (ø)
jina/drivers/predict.py 88.70% <ø> (ø)
jina/drivers/querylang/filter.py 100.00% <ø> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f1b0e...4de1b2f. Read the comment docs.

Yongxuanzhang
Yongxuanzhang reviewed Mar 11, 2021
View reviewed changes
jina/drivers/evaluate.py Outdated Show resolved Hide resolved
jina/drivers/evaluate.py Outdated Show resolved Hide resolved
jina/drivers/querylang/filter.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 11, 2021 •
edited

Latency summary

Current PR yields:

  • 😶 index QPS at 1176, delta to last 3 avg.: +0%
  • 😶 query QPS at 19, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1176 19
1.0.8 1178 20
1.0.7 1158 19

Backed by latency-tracking. Further commits will update this comment.

@florian-hoenicke florian-hoenicke marked this pull request as ready for review March 12, 2021 08:11
@florian-hoenicke florian-hoenicke requested a review from a team as a code owner March 12, 2021 08:11
@florian-hoenicke florian-hoenicke linked an issue Mar 12, 2021 that may be closed by this pull request
docs kwargs without unpacking #2160
Closed
maximilianwerk
maximilianwerk requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we touch it now, I'd like to touch it for good and include the context again.

jina/drivers/rank/aggregate/__init__.py Show resolved Hide resolved
cristianmtr
cristianmtr suggested changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@cristianmtr cristianmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@florian-hoenicke
Copy link
Member Author

@cristianmtr @maximilianwerk Is there anything left to do?

@florian-hoenicke florian-hoenicke merged commit 0f88deb into master Mar 15, 2021
@florian-hoenicke florian-hoenicke deleted the docs-kwargs-without-unpacking branch March 15, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@maximilianwerk maximilianwerk maximilianwerk approved these changes

@cristianmtr cristianmtr cristianmtr approved these changes

@deepankarm deepankarm Awaiting requested review from deepankarm

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/client component/driver component/executor component/flow component/jaml component/type executor/crafter executor/indexer size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs kwargs without unpacking
5 participants
@florian-hoenicke @maximilianwerk @cristianmtr @Yongxuanzhang @jina-bot