Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove folder after test #2162

Merged
merged 1 commit into from Mar 12, 2021
Merged

Conversation

maximilianwerk
Copy link
Member

#2105 is partially fixed with this PR.

@maximilianwerk maximilianwerk requested a review from a team as a code owner March 12, 2021 10:55
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #2162 (d339071) into master (982fd9e) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2162      +/-   ##
==========================================
- Coverage   90.46%   90.37%   -0.09%     
==========================================
  Files         211      211              
  Lines       11239    11239              
==========================================
- Hits        10167    10157      -10     
- Misses       1072     1082      +10     
Flag Coverage Δ
daemon 50.29% <ø> (ø)
jina 90.82% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/base.py 80.83% <0.00%> (-2.50%) ⬇️
jina/peapods/zmq/__init__.py 79.87% <0.00%> (-2.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982fd9e...d339071. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1176, delta to last 3 avg.: +0%
  • 😶 query QPS at 20, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1176 20
1.0.8 1186 19
1.0.7 1152 20

Backed by latency-tracking. Further commits will update this comment.

@maximilianwerk maximilianwerk merged commit 3dd0f53 into master Mar 12, 2021
@maximilianwerk maximilianwerk deleted the test-delete-folder-after-test branch March 12, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants