Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: complete pod tests #2164

Merged
merged 4 commits into from Mar 14, 2021
Merged

test: complete pod tests #2164

merged 4 commits into from Mar 14, 2021

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Mar 14, 2021

this pr should make pods/__init__.py coverage close to 100%.

@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Mar 14, 2021
@bwanglzu bwanglzu self-assigned this Mar 14, 2021
@bwanglzu bwanglzu marked this pull request as ready for review March 14, 2021 10:24
@bwanglzu bwanglzu requested a review from a team as a code owner March 14, 2021 10:24
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #2164 (83f1f08) into master (2940582) will increase coverage by 1.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2164      +/-   ##
==========================================
+ Coverage   88.86%   90.46%   +1.59%     
==========================================
  Files         211      211              
  Lines       11263    11263              
==========================================
+ Hits        10009    10189     +180     
+ Misses       1254     1074     -180     
Flag Coverage Δ
daemon 50.22% <ø> (ø)
jina 90.92% <ø> (+1.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 83.65% <0.00%> (+0.84%) ⬆️
jina/types/message/__init__.py 88.20% <0.00%> (+1.53%) ⬆️
jina/drivers/control.py 95.08% <0.00%> (+1.63%) ⬆️
jina/clients/base.py 83.33% <0.00%> (+1.66%) ⬆️
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (+2.18%) ⬆️
jina/docker/hubio.py 84.11% <0.00%> (+2.23%) ⬆️
jina/drivers/convertdriver.py 97.22% <0.00%> (+2.77%) ⬆️
jina/flow/mixin/crud.py 89.65% <0.00%> (+3.44%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 95.91% <0.00%> (+4.08%) ⬆️
jina/clients/helper.py 100.00% <0.00%> (+4.54%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f1b0e...83f1f08. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 14, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1115, delta to last 3 avg.: +0%
  • 😶 query QPS at 18, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1115 18
1.0.8 1111 18
1.0.7 1103 18

Backed by latency-tracking. Further commits will update this comment.

@florian-hoenicke florian-hoenicke merged commit 95c689f into master Mar 14, 2021
@florian-hoenicke florian-hoenicke deleted the test-add-pod branch March 14, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants