Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix docstring in search driver #2174

Merged
merged 1 commit into from Mar 16, 2021
Merged

docs: fix docstring in search driver #2174

merged 1 commit into from Mar 16, 2021

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Mar 16, 2021

discovered while writing docs.

@bwanglzu bwanglzu requested a review from a team as a code owner March 16, 2021 04:25
@bwanglzu bwanglzu self-assigned this Mar 16, 2021
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/driver labels Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #2174 (2d017d7) into master (b3550e9) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2174      +/-   ##
==========================================
+ Coverage   90.37%   90.46%   +0.08%     
==========================================
  Files         211      211              
  Lines       11269    11269              
==========================================
+ Hits        10184    10194      +10     
+ Misses       1085     1075      -10     
Flag Coverage Δ
daemon 50.24% <ø> (ø)
jina 90.91% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/drivers/search.py 98.18% <ø> (ø)
jina/peapods/zmq/__init__.py 82.01% <0.00%> (+2.13%) ⬆️
jina/clients/base.py 83.33% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3550e9...2d017d7. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1175, delta to last 3 avg.: +2%
  • 😶 query QPS at 20, delta to last 3 avg.: +3%

Breakdown

Version Index QPS Query QPS
current 1175 20
1.0.9 1169 19
1.0.8 1127 19

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit b3d2f77 into master Mar 16, 2021
@nan-wang nan-wang deleted the fix-driver-docs branch March 16, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/driver size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants