Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #2179

Merged
merged 1 commit into from
Mar 16, 2021
Merged

docs: fix typo #2179

merged 1 commit into from
Mar 16, 2021

Conversation

cristianmtr
Copy link
Contributor

No description provided.

bwanglzu
bwanglzu previously approved these changes Mar 16, 2021
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! lol

@florian-hoenicke
Copy link
Member

Oh that was my copy past fault. Good that you fixed it.

@github-actions
Copy link

github-actions bot commented Mar 16, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1087, delta to last 3 avg.: +1%
  • 😶 query QPS at 18, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1087 18
1.0.10 1070 18
1.0.9 1082 18

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #2179 (ab88d62) into master (e3403fb) will increase coverage by 1.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2179      +/-   ##
==========================================
+ Coverage   89.35%   90.50%   +1.14%     
==========================================
  Files         208      208              
  Lines       11243    11243              
==========================================
+ Hits        10046    10175     +129     
+ Misses       1197     1068     -129     
Flag Coverage Δ
daemon 50.20% <ø> (ø)
jina 90.96% <ø> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/drivers/__init__.py 93.90% <ø> (ø)
jina/drivers/cache.py 94.59% <ø> (ø)
jina/drivers/control.py 95.00% <ø> (ø)
jina/drivers/convertdriver.py 97.22% <ø> (ø)
jina/drivers/evaluate.py 100.00% <ø> (ø)
jina/drivers/predict.py 88.70% <ø> (ø)
jina/drivers/querylang/filter.py 100.00% <ø> (ø)
jina/drivers/querylang/select.py 89.65% <ø> (ø)
jina/drivers/querylang/slice.py 94.44% <ø> (ø)
jina/drivers/querylang/sort.py 100.00% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3403fb...ab88d62. Read the comment docs.

@cristianmtr
Copy link
Contributor Author

cristianmtr commented Mar 16, 2021

Oh that was my copy past fault. Good that you fixed it.

Oh that was my copy paste fault. Good that you fixed it. 😛

@cristianmtr cristianmtr merged commit 3bf8c15 into master Mar 16, 2021
@cristianmtr cristianmtr deleted the docs-fix-wich-typo branch March 16, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants