Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(helper): merge single and single_multi_input into one #2192

Merged
merged 6 commits into from Mar 17, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Mar 17, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner March 17, 2021 02:29
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/meta labels Mar 17, 2021
@Yongxuanzhang
Copy link
Contributor

Maybe need to merge/rebase master to pass docstring and black CI?

@github-actions
Copy link

github-actions bot commented Mar 17, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 937, delta to last 3 avg.: +0%
  • 😶 query QPS at 13, delta to last 3 avg.: -5%

Breakdown

Version Index QPS Query QPS
current 937 13
1.0.10 944 13
1.0.9 934 13

Backed by latency-tracking. Further commits will update this comment.

@nan-wang
Copy link
Member

The executors in jina-hub need to be adapted as well.

https://github.com/jina-ai/jina-hub/search?q=single_multi_input

@jina-bot jina-bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #2192 (14fc323) into master (b5f8010) will decrease coverage by 2.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2192      +/-   ##
==========================================
- Coverage   90.50%   87.80%   -2.71%     
==========================================
  Files         208      208              
  Lines       11243    11222      -21     
==========================================
- Hits        10175     9853     -322     
- Misses       1068     1369     +301     
Flag Coverage Δ
daemon 50.24% <9.09%> (+0.04%) ⬆️
jina 88.12% <100.00%> (-2.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/drivers/segment.py 78.12% <ø> (+2.36%) ⬆️
jina/executors/decorators.py 94.24% <100.00%> (-0.08%) ⬇️
jina/schemas/pod.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/flow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/meta.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/driver.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/request.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/executor.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/__init__.py 7.14% <0.00%> (-92.86%) ⬇️
jina/parsers/export_api.py 0.00% <0.00%> (-87.50%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f8010...14fc323. Read the comment docs.

@hanxiao hanxiao merged commit abceba0 into master Mar 17, 2021
@hanxiao hanxiao deleted the refactor-single-decor branch March 17, 2021 08:53
@JoanFM
Copy link
Member

JoanFM commented Mar 17, 2021

Documentation needs update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/driver component/executor executor/meta size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants