Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix multimodal example #2195

Merged
merged 7 commits into from
Mar 17, 2021
Merged

fix: fix multimodal example #2195

merged 7 commits into from
Mar 17, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 17, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner March 17, 2021 11:09
@JoanFM JoanFM changed the title Fix multimodal seg fix: fix multimodal example Mar 17, 2021
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/resource component/type labels Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #2195 (935be23) into master (abceba0) will increase coverage by 2.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2195      +/-   ##
==========================================
+ Coverage   87.54%   90.51%   +2.97%     
==========================================
  Files         208      208              
  Lines       11222    11222              
==========================================
+ Hits         9824    10158     +334     
+ Misses       1398     1064     -334     
Flag Coverage Δ
daemon 50.24% <0.00%> (-28.32%) ⬇️
jina 90.98% <100.00%> (+2.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/sets/document.py 94.73% <100.00%> (ø)
jina/types/document/__init__.py 91.89% <0.00%> (-0.26%) ⬇️
jina/peapods/runtimes/zmq/zed.py 92.90% <0.00%> (+1.41%) ⬆️
jina/executors/compound.py 89.31% <0.00%> (+1.52%) ⬆️
jina/jaml/helper.py 93.89% <0.00%> (+2.29%) ⬆️
jina/clients/base.py 83.33% <0.00%> (+2.50%) ⬆️
jina/peapods/zmq/__init__.py 82.01% <0.00%> (+2.74%) ⬆️
jina/drivers/segment.py 81.25% <0.00%> (+3.12%) ⬆️
jina/jaml/__init__.py 96.25% <0.00%> (+4.27%) ⬆️
jina/drivers/control.py 95.00% <0.00%> (+5.00%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abceba0...935be23. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 17, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 927, delta to last 3 avg.: +0%
  • 😶 query QPS at 13, delta to last 3 avg.: -5%

Breakdown

Version Index QPS Query QPS
current 927 13
1.0.10 933 13
1.0.9 929 13

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 3caf7df into master Mar 17, 2021
@hanxiao hanxiao deleted the fix-multimodal-seg branch March 17, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/resource component/type size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants