Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use import extensions #2204

Merged
merged 1 commit into from Mar 19, 2021
Merged

fix: use import extensions #2204

merged 1 commit into from Mar 19, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 18, 2021

No description provided.

Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this change raise ModuleNotFoundError?

@github-actions
Copy link

github-actions bot commented Mar 18, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1179, delta to last 3 avg.: -1%
  • 😶 query QPS at 20, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1179 20
1.0.11 1199 20
1.0.10 1199 20

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #2204 (4e14908) into master (8c3f1e9) will increase coverage by 0.22%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2204      +/-   ##
==========================================
+ Coverage   90.26%   90.48%   +0.22%     
==========================================
  Files         208      208              
  Lines       11231    11230       -1     
==========================================
+ Hits        10138    10162      +24     
+ Misses       1093     1068      -25     
Flag Coverage Δ
daemon 50.25% <44.44%> (+0.02%) ⬆️
jina 90.95% <66.66%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/logging/profile.py 96.09% <40.00%> (+0.78%) ⬆️
jina/__init__.py 73.49% <100.00%> (ø)
jina/executors/indexers/vector.py 96.53% <100.00%> (+0.84%) ⬆️
jina/peapods/runtimes/zmq/zed.py 91.48% <0.00%> (-1.42%) ⬇️
jina/executors/indexers/keyvalue.py 99.21% <0.00%> (+0.78%) ⬆️
jina/drivers/search.py 98.18% <0.00%> (+1.81%) ⬆️
jina/peapods/runtimes/asyncio/rest/app.py 93.52% <0.00%> (+15.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e93b64...4e14908. Read the comment docs.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@JoanFM JoanFM merged commit f7e3355 into master Mar 19, 2021
@JoanFM JoanFM deleted the fix-import-extensions branch March 19, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants