Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): allow uses for Executor class #2215

Merged
merged 1 commit into from Mar 21, 2021
Merged

feat(flow): allow uses for Executor class #2215

merged 1 commit into from Mar 21, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Mar 21, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner March 21, 2021 05:36
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing labels Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #2215 (0a17114) into master (762f619) will decrease coverage by 1.30%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2215      +/-   ##
==========================================
- Coverage   90.44%   89.13%   -1.31%     
==========================================
  Files         208      208              
  Lines       11218    11221       +3     
==========================================
- Hits        10146    10002     -144     
- Misses       1072     1219     +147     
Flag Coverage Δ
daemon 50.27% <75.00%> (+0.01%) ⬆️
jina 89.48% <75.00%> (-1.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 82.70% <66.66%> (-0.96%) ⬇️
jina/__init__.py 73.49% <100.00%> (ø)
jina/jaml/parsers/flow/v1.py 48.14% <0.00%> (-44.45%) ⬇️
jina/clients/asyncio.py 50.00% <0.00%> (-40.63%) ⬇️
jina/jaml/parsers/flow/legacy.py 22.72% <0.00%> (-20.46%) ⬇️
jina/flow/mixin/async_crud.py 44.59% <0.00%> (-14.87%) ⬇️
jina/flow/base.py 78.00% <0.00%> (-14.58%) ⬇️
jina/flow/asyncio.py 75.00% <0.00%> (-12.50%) ⬇️
jina/jaml/helper.py 87.02% <0.00%> (-6.88%) ⬇️
jina/jaml/parsers/__init__.py 93.61% <0.00%> (-6.39%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3514bf1...0a17114. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 962, delta to last 3 avg.: -1%
  • 🐢🐢 query QPS at 13, delta to last 3 avg.: -9%

Breakdown

Version Index QPS Query QPS
current 962 13
1.0.12 982 14
1.0.11 978 14

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 3879045 into master Mar 21, 2021
@hanxiao hanxiao deleted the feat-uses-cls branch March 21, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants