Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jaml): allow loading from flatten Flow yaml #2216

Merged
merged 1 commit into from Mar 21, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Mar 21, 2021

This enables the loading from a "flattened" Flow YAML, e.g.

jtype: Flow
version: '1'
pods:
  - uses:
    jtype: CustomizedEncoder
    requests:
      on:
        IndexRequest:
          - jtype: FilterQL
            with:
              lookups: { modality__in: [ mode2 ] }
              traversal_paths: [ 'c' ]
          - jtype: EncodeDriver
            with:
              method: encode
              traversal_paths: [ 'c' ]
  - uses: _index
  - uses:
    jtype: BaseEncoder
    metas:
      name: test_indexer
      workspace: ./indexed

@hanxiao hanxiao requested a review from a team as a code owner March 21, 2021 13:12
@hanxiao hanxiao requested review from imsergiy and JoanFM March 21, 2021 13:12
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/jaml component/resource labels Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #2216 (a456007) into master (3879045) will decrease coverage by 1.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2216      +/-   ##
==========================================
- Coverage   90.51%   88.53%   -1.99%     
==========================================
  Files         208      208              
  Lines       11221    11226       +5     
==========================================
- Hits        10157     9939     -218     
- Misses       1064     1287     +223     
Flag Coverage Δ
daemon 50.26% <55.55%> (-0.01%) ⬇️
jina 88.85% <100.00%> (-2.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/helloworld.py 98.21% <ø> (-0.04%) ⬇️
jina/jaml/__init__.py 96.37% <100.00%> (+0.11%) ⬆️
jina/jaml/parsers/flow/v1.py 48.14% <0.00%> (-44.45%) ⬇️
jina/clients/asyncio.py 50.00% <0.00%> (-40.63%) ⬇️
jina/flow/base.py 60.86% <0.00%> (-31.72%) ⬇️
jina/jaml/parsers/flow/legacy.py 22.72% <0.00%> (-20.46%) ⬇️
jina/flow/mixin/async_crud.py 44.59% <0.00%> (-14.87%) ⬇️
jina/flow/asyncio.py 75.00% <0.00%> (-12.50%) ⬇️
jina/jaml/helper.py 87.02% <0.00%> (-6.88%) ⬇️
jina/jaml/parsers/__init__.py 93.61% <0.00%> (-6.39%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d4319...a456007. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1008, delta to last 3 avg.: -4%
  • 😶 query QPS at 17, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1008 17
1.0.12 1057 17

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 7c658a0 into master Mar 21, 2021
@hanxiao hanxiao deleted the feat-all-in-one-flow branch March 21, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/jaml component/resource size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants