fix: test expects file with contents #2221
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2221 +/- ##
==========================================
- Coverage 90.43% 90.42% -0.01%
==========================================
Files 208 208
Lines 11253 11253
==========================================
- Hits 10177 10176 -1
- Misses 1076 1077 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
cristianmtr
force-pushed
the
fix-index-files
branch
from
d8ac7b0
to
b03f921
Compare
tests/unit/flow/test_flow.py
Outdated
| @@ -409,9 +409,9 @@ def validate(req): | |||
| f = Flow(restful=restful, read_only=True).add( | |||
| uses=os.path.join(cur_dir, '../yaml/datauriindex.yml'), timeout_ready=-1 | |||
| ) | |||
|
|
|||
| files = os.path.join(cur_dir, '*.py') | |||
There was a problem hiding this comment.
interesting that we use python files as text input.
Wouldn't it be better to create files in the tmpdir instead of reading from the program code
There was a problem hiding this comment.
We can just use the yaml files. We know these will always have content
cristianmtr
force-pushed
the
fix-index-files
branch
from
b03f921
to
e208118
Compare
|
good catch! |
Test expects all
.pyfiles in its dir to have contents. Ensure they all do, and ensure it always checks the same files, no matter where you're running it from