Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: assert there are no embeddings by default #2229

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

CatStark
Copy link
Member

(The previous branch had a mess while rebasing master. This is the same but the updated master will prevents the other tests in CI to fail)

As discussed here right now there is no way to access the embedding. They are being excluded by default during query time.
It refers to this issue

@CatStark CatStark requested a review from a team as a code owner March 24, 2021 08:18
@CatStark CatStark requested review from davidbp and removed request for davidbp March 24, 2021 08:18
@jina-bot jina-bot added size/XS area/testing This issue/PR affects testing labels Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #2229 (2ef2efa) into master (9b3ab47) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2229      +/-   ##
==========================================
+ Coverage   90.42%   90.44%   +0.01%     
==========================================
  Files         208      208              
  Lines       11253    11253              
==========================================
+ Hits        10176    10178       +2     
+ Misses       1077     1075       -2     
Flag Coverage Δ
daemon 51.25% <ø> (ø)
jina 90.90% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/zmq/zed.py 92.90% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3ab47...2ef2efa. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1003, delta to last 3 avg.: +1%
  • 😶 query QPS at 14, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1003 14
1.0.15 1008 14
1.0.14 976 14

Backed by latency-tracking. Further commits will update this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants