Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add zmq runtime test #2230

Merged
merged 2 commits into from Mar 25, 2021
Merged

test: add zmq runtime test #2230

merged 2 commits into from Mar 25, 2021

Conversation

bwanglzu
Copy link
Member

this pr should completes unit tests for ZMQManyRuntime .

@bwanglzu bwanglzu self-assigned this Mar 24, 2021
@bwanglzu bwanglzu requested a review from a team as a code owner March 24, 2021 11:21
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #2230 (428bf61) into master (8b80cec) will increase coverage by 1.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
+ Coverage   89.03%   90.58%   +1.55%     
==========================================
  Files         208      208              
  Lines       11253    11253              
==========================================
+ Hits        10019    10194     +175     
+ Misses       1234     1059     -175     
Flag Coverage Δ
daemon 51.25% <ø> (ø)
jina 91.05% <ø> (+1.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 83.75% <0.00%> (+1.05%) ⬆️
jina/clients/base.py 82.64% <0.00%> (+1.65%) ⬆️
jina/drivers/control.py 95.00% <0.00%> (+1.66%) ⬆️
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (+2.18%) ⬆️
jina/types/message/__init__.py 88.20% <0.00%> (+2.56%) ⬆️
jina/drivers/convert.py 97.22% <0.00%> (+2.77%) ⬆️
jina/flow/mixin/crud.py 89.65% <0.00%> (+3.44%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 95.91% <0.00%> (+4.08%) ⬆️
jina/clients/helper.py 100.00% <0.00%> (+4.54%) ⬆️
jina/peapods/runtimes/zmq/zed.py 92.90% <0.00%> (+4.96%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b80cec...428bf61. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 24, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1047, delta to last 3 avg.: -2%
  • 😶 query QPS at 17, delta to last 3 avg.: -5%

Breakdown

Version Index QPS Query QPS
current 1047 17
1.0.15 1084 18
1.0.14 1061 17

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 1c9949c into master Mar 25, 2021
@nan-wang nan-wang deleted the test-add-zmqruntime branch March 25, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants