Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: peas start at index 0 #2243

Merged
merged 1 commit into from
Mar 30, 2021
Merged

feat: peas start at index 0 #2243

merged 1 commit into from
Mar 30, 2021

Conversation

cristianmtr
Copy link
Contributor

@cristianmtr cristianmtr commented Mar 26, 2021

Trying to make all pea ids start at 0.

This is a breaking change!

@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/executor component/peapod executor/meta labels Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #2243 (b71ef5f) into master (2ad1a5e) will increase coverage by 2.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2243      +/-   ##
==========================================
+ Coverage   87.82%   90.62%   +2.80%     
==========================================
  Files         209      209              
  Lines       11313    11312       -1     
==========================================
+ Hits         9936    10252     +316     
+ Misses       1377     1060     -317     
Flag Coverage Δ
daemon 51.17% <50.00%> (+<0.01%) ⬆️
jina 91.09% <100.00%> (+2.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 73.49% <100.00%> (ø)
jina/executors/__init__.py 92.27% <100.00%> (ø)
jina/helloworld/multimodal/__init__.py 90.90% <100.00%> (+90.90%) ⬆️
jina/peapods/pods/helper.py 97.89% <100.00%> (-0.03%) ⬇️
jina/drivers/evaluate.py 100.00% <0.00%> (+1.40%) ⬆️
jina/clients/base.py 82.64% <0.00%> (+1.65%) ⬆️
jina/drivers/control.py 95.00% <0.00%> (+1.66%) ⬆️
jina/peapods/runtimes/jinad/client.py 82.48% <0.00%> (+2.18%) ⬆️
jina/types/message/__init__.py 88.20% <0.00%> (+2.56%) ⬆️
jina/logging/profile.py 96.09% <0.00%> (+3.12%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679d58b...b71ef5f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 26, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 927, delta to last 3 avg.: +3%
  • 😶 query QPS at 13, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 927 13
1.1.0 927 13
1.0.16 870 13

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added size/S area/testing This issue/PR affects testing and removed size/XS labels Mar 26, 2021
@cristianmtr cristianmtr force-pushed the feat-pea-ids-index branch 5 times, most recently from 9c43749 to c7e9acc Compare March 26, 2021 14:34
@jina-bot jina-bot added size/M and removed size/S labels Mar 26, 2021
@cristianmtr cristianmtr force-pushed the feat-pea-ids-index branch 3 times, most recently from aef5472 to 294f1ce Compare March 26, 2021 15:59
@cristianmtr cristianmtr requested review from hanxiao, florian-hoenicke, maximilianwerk and nan-wang and removed request for hanxiao March 26, 2021 16:22
@cristianmtr cristianmtr marked this pull request as ready for review March 26, 2021 16:23
@cristianmtr cristianmtr requested a review from a team as a code owner March 26, 2021 16:23
@nan-wang
Copy link
Member

Let's hold this one for the 1.2 because this will introduce quite some changes for the dashboard.

@cristianmtr
Copy link
Contributor Author

Let's hold this one for the 1.2 because this will introduce quite some changes for the dashboard.

So merge it after the 1.1 release? When will that be? If we keep adding tests in master it would mean more work to adapt them to this PR

@hanxiao hanxiao merged commit 917de4b into master Mar 30, 2021
@hanxiao hanxiao deleted the feat-pea-ids-index branch March 30, 2021 04:38
@nan-wang nan-wang added this to the v1.2 Breaking Changes milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/executor component/peapod executor/meta size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants